lukecwik edited a comment on pull request #13006: URL: https://github.com/apache/beam/pull/13006#issuecomment-703824659
> I did a first pass. I think big picture there are two things: > > 1. Without unfolding all the code not in the code review, I am not already familiar with the expected level of SDF support of all the runners. Some of them seem to previously reject non-SDF reads but now could end up having non-SDF reads. BEAM-10670 is about migrating all runners to use SDF first and only SDF. All runners that supported BoundedSource/UnboundedSource support SDF to the level necessary to execute the BoundedSource/UnboundedSource as SDF wrappers. The only ones that don't are Spark (underway in #12603) and Dataflow runner v1 which would have a degraded experience in batch and would break pipeline update in streaming. This was a focus of mine over the past ~6 weeks. > 2. I do not think runners core construction should be manipulated by global flags, but each runner should decide what to do with the flag, if anything. If a runner has a well-used non-portable variant that is not going away any time soon, then it can still use the portable pipeline and just reject any with non-Java UDFs. If a runner only supports SDF in some modes but only supports Read in others, or wants to translate Read specially for efficiency (or any other reason it wants to - it can do whatever it wants) then it can do that. I can do that but it seems like it will lead to possible inconsistency across runners around how this choice is made. Currently CHANGES.md says to get the old behavior use this flag and it would be unfortunate to say "consult the runner documentation as to how to get the old behavior". After a few releases, the intent is that this logic is removed from runners-core and everyone except for Dataflow v1 runner always use the SDF wrapper and we move the necessary logic within runners-core to the Dataflow module deleting the remainder (the PrimitiveBoundedRead override). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
