damccorm commented on PR #38313: URL: https://github.com/apache/beam/pull/38313#issuecomment-5697882288
> @damccorm As to your suggestion, I'm not sure if Beam has a good way of knowing whether an option was explicitly set. i.e. if we change the default, BigQueryOptions.getUseStorageApiConnectionPool() == true could not distinguish between a user who explicitly set the option and one who is getting the new default. If we always turn connection pooling off when AutoSchemaUpdate is used, we may regress performance for existing users who are explicitly enabling connection pooling. Could we make the option Nullable (and default null)? That gives us 3 states: - null (nothing set) - true (set by user) - false (set by user) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
