jrmccluskey commented on code in PR #40222:
URL: https://github.com/apache/beam/pull/40222#discussion_r4083994997
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/TableMetadataDriver.java:
##########
@@ -340,7 +414,17 @@ public void processElement(
dynamicDestinations.getTableStringIdentifier(
ValueInSingleWindow.of(element, timestamp, window, paneInfo));
if (tableIdentifier != null && !tableIdentifier.trim().isEmpty()) {
- out.output(tableIdentifier.trim());
+ String canonicalId = tableIdentifier.trim();
+ if (localTableIdCache == null && refreshInterval != null) {
+ initCache();
+ }
Review Comment:
removed, was a codegen add-in because a unit test directly called
ProcessElement() without calling setup() first and the obvious "fix" was to
check that the cache was initialized in ProcessElement()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
