jrmccluskey commented on code in PR #40222:
URL: https://github.com/apache/beam/pull/40222#discussion_r4083997369
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/TableMetadataDriver.java:
##########
@@ -125,6 +129,9 @@ public interface Clock extends Serializable {
*/
public abstract @Nullable Integer getPollingBuckets();
+ @VisibleForTesting
+ public abstract @Nullable Clock getClock();
+
Review Comment:
done
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/TableMetadataDriver.java:
##########
@@ -340,7 +414,17 @@ public void processElement(
dynamicDestinations.getTableStringIdentifier(
ValueInSingleWindow.of(element, timestamp, window, paneInfo));
if (tableIdentifier != null && !tableIdentifier.trim().isEmpty()) {
- out.output(tableIdentifier.trim());
+ String canonicalId = tableIdentifier.trim();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
