bvolpato commented on PR #39996: URL: https://github.com/apache/beam/pull/39996#issuecomment-5884175282
I reproduced the key collision with the two regression tests added here. Each test runs in both asyncio and thread-pool modes. The test file was copied from this PR unchanged and run against each revision's `async_dofn.py` with Python 3.12.13: - Original pre-fix parent `ffcbd7e464f8244bd623d23e7fa9fcc750e81bbb`: 4 failed. - Current Apache Beam master `b4db8d2a11d6b2796a98a149ea0c6709d97d6b36`: 4 failed. - This PR head `ec16d879834ca4b7da40980cbac7dbfbbb51abf7`: 4 passed. On both failing revisions, committing key 2's state returned key 1's result for equal values and for matching custom IDs. To rerun, from the repository root: ```sh git show ec16d879834ca4b7da40980cbac7dbfbbb51abf7:sdks/python/apache_beam/transforms/async_dofn_test.py > /tmp/async_dofn_pr_test.py cd sdks/python PYTHONPATH=. python -m pytest /tmp/async_dofn_pr_test.py -k 'equal_values_in_different_keys or custom_ids_are_scoped_to_key' -vv ``` Run those commands with the source checkout at each revision above; the `PYTHONPATH` makes the tests exercise that checkout's SDK code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
