damccorm commented on code in PR #40372:
URL: https://github.com/apache/beam/pull/40372#discussion_r4156516560
##########
.github/workflows/beam_PreCommit_Java_Dataflow.yml:
##########
@@ -111,6 +112,7 @@ jobs:
with:
commit: '${{ env.prsha || env.GITHUB_SHA }}'
comment_mode: ${{ github.event_name == 'issue_comment' && 'always'
|| 'off' }}
+ check_run: ${{ github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository }}
Review Comment:
Right now, we always publish the results as a GHA check run (so you can view
the results in the UI without clicking into the action). Tbh, it doesn't work
very well, but it may actually work better with pull_request than
pull_request_target.
This change modifies the behavior to not publish this when running on a
pull_request from a fork because the GitHub token will not be sufficiently
provisioned to do so.
https://github.com/EnricoMi/publish-unit-test-result-action/blob/071ec54125241f64de06e2a790236c1fd8ce9dce/action.yml#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
