damccorm commented on code in PR #40372:
URL: https://github.com/apache/beam/pull/40372#discussion_r4158226554
##########
.github/workflows/beam_PreCommit_Java_Cdap_IO_Direct.yml:
##########
@@ -120,7 +121,7 @@ jobs:
path: '**/build/reports/spotbugs/*.html'
- name: Publish SpotBugs Results
uses: jwgmeligmeyling/[email protected]
- if: always()
+ if: always() && (github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository)
Review Comment:
Actually, this would (surprisingly) change the behavior.
If an if: condition does not include a status check function (e.g.
`always()`, `failure()`, etc...), GitHub Actions automatically prepends
`success() &&` to the expression. See
https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#status-check-functions
##########
.github/workflows/beam_PreCommit_Java_Cdap_IO_Direct.yml:
##########
@@ -120,7 +121,7 @@ jobs:
path: '**/build/reports/spotbugs/*.html'
- name: Publish SpotBugs Results
uses: jwgmeligmeyling/[email protected]
- if: always()
+ if: always() && (github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository)
Review Comment:
Actually, this would (surprisingly) change the behavior.
If an `if:` condition does not include a status check function (e.g.
`always()`, `failure()`, etc...), GitHub Actions automatically prepends
`success() &&` to the expression. See
https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#status-check-functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
