Abacn commented on code in PR #40315: URL: https://github.com/apache/beam/pull/40315#discussion_r4196852313
########## .github/REVIEWERS.yml: ########## @@ -17,14 +17,18 @@ # add yourself to that label's exclusionList # FallbackReviewers is for reviewers who can review any area of the code base that might # not receive a label. These should generally be more experienced committers. +# Priority determines which label is used to select a reviewer when a PR has multiple labels +# (lower number = higher priority). Review Comment: Sorry missed the info. iiuc the assumption here is multiple reviewer assignment caused unclear responsibility. There is active developing topics (like iceberg) that has active reviewers. This approach improves both reviewer and contributor experience when top priority tag reviewer is active. A con I could imagine is that if fewer people get pinned and the primary reviewer is unavailable at the time, it might reduce the observability of the contribution and less likely get reviewed. Personally I check GItHub notifications regularly so at least I am aware of new PRs that get tagged. If both are true we can pin more reviewers, either current approach, or from both priority x and x+1 if the assigned reviewer is unresponsive and reassigning reviewer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
