damccorm commented on code in PR #40315: URL: https://github.com/apache/beam/pull/40315#discussion_r4219770680
########## .github/REVIEWERS.yml: ########## @@ -17,14 +17,18 @@ # add yourself to that label's exclusionList # FallbackReviewers is for reviewers who can review any area of the code base that might # not receive a label. These should generally be more experienced committers. +# Priority determines which label is used to select a reviewer when a PR has multiple labels +# (lower number = higher priority). Review Comment: > A con I could imagine is that for a tag where primary reviewers are less active, or is unavailable at the time, it might reduce the observability of the contribution and less likely get reviewed. Personally I check GItHub notifications regularly so at least I am aware of new PRs that get tagged. Right now some PRs tag one person and some PRs tag multiple people. My experience is that PRs with a single reviewer tend to get reviewed faster. With that said, I agree with your concern; I think that we can manage this separately by having monitoring tooling that allows us to see reviews that have fallen behind. I've already started doing this for myself and sending alerts to people I know (mostly other googlers as of now). > If both are true we can pin more reviewers, either current approach, or from both priority x and x+1 if the assigned reviewer is unresponsive and reassigning reviewer? I do include a backup reviewer here (already in this PR), but I leave it up to the PR author's discretion on whether they should engage them. That way if they notice that they're not getting traction, they can ask for help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
