Abacn opened a new pull request, #40458:
URL: https://github.com/apache/beam/pull/40458
- Remove `'passed'` from default `testLogging` events in `BeamModulePlugin`
so only skipped/failed tests and per-task summaries are logged.
- Downgrade the CI Maven Central mirror log message from `lifecycle` to
`debug` in `Repositories.groovy` and `settings.gradle.kts` to avoid repeating
it for every subproject.
- Remove `showStandardStreams = true` and `outputs.upToDateWhen {false}`
overrides from `needsRunnerTests` and `examplesIntegrationTest` in
`:runners:direct-java`, `:sdks:java:io:debezium`. If workflow failes, these
logs are available from junit-test-result.zip downloading from workflow run
summary page
After GHA workflow changed `pull_request_target` -> `pull_request` trigger,
failed tests on PR run no longer publish status, and one needs to either dig
into test log or download junit-test-report. Test log currently has a few
spammy logs:
| Rank | Category | Line Count | % of Total Log | Primary Cause |
| :--- | :--- | ---: | ---: | :--- |
| **1** | **Gradle Per-Test `PASSED` / `SKIPPED` Events & Trailing Blank
Lines** | **19,506** | **51.65%** | `testLogging { events 'passed', 'skipped',
'failed' }` in `BeamModulePlugin.groovy` |
| **2** | **`:runners:direct-java:needsRunnerTests` Standard Error (`SLF4J`
INFO/WARN)** | **6,472** | **17.14%** | `showStandardStreams = true` in
`runners/direct-java/build.gradle` + noisy `INFO`/`WARN` loggers in SDK Core |
| **3** | **JMH Benchmark Execution (`:sdks:java:harness:jmh:jmhTest` &
`:core:jmh:jmhTest`)** | **4,440** | **11.76%** | `System.out.println` in
`ExecutionStateSamplerBenchmark`, JMH runner banners, and unclosed gRPC
channels |
| **4** | **Gradle Task Execution Headers (`> Task :...`) & Blank
Separators** | **~2,500** | **6.62%** | 2,249 Gradle task headers (1,612
executed, 316 skipped, 242 no-source, etc.) |
| **5** | **SpotBugs Missing Class Warnings
(`:sdks:java:extensions:avro:spotbugsAvro*`)** | **1,174** | **3.11%** |
`spotbugsAvro182`/`192`/`1102`/`1113` running with `ignoreFailures = true` and
missing auxiliary classpath |
| **6** | **Compiler (`javac`) & Javadoc Warnings** | **~380** | **1.01%** |
Deprecation/unchecked notes and invalid `<` HTML in Javadoc comments |
| **7** | **Gradle Project Configuration & Maven Mirror Lifecycle Logs** |
**328** | **0.87%** | `logger.lifecycle("Running in CI. Mirroring Maven
Central...")` logged per subproject (110 times) |
| **8** | **Flink Test Shutdown Hook & Finalizer `INFO` Logs** | **296** |
**0.78%** | `slf4j-simple` used instead of `log4j` in `flink_runner.gradle`,
logging at `INFO` during JVM shutdown/GC |
| **9** | **Prism Subprocess Error Output (`:runners:prism:java:test`)** |
**~240** | **0.64%** | `PrismExecutor` using `ProcessBuilder.inheritIO()`
during intentional failure tests |
This PR reduces **1**, **2**, **7**, reduce logging lines by ~65%.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
for a list of workflows and how to trigger them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
