Abacn commented on code in PR #40458:
URL: https://github.com/apache/beam/pull/40458#discussion_r4222279379
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1265,15 +1265,10 @@ class BeamModulePlugin implements Plugin<Project> {
if (System.getProperty("os.name").toLowerCase().contains("windows")) {
systemProperty 'org.xerial.snappy.tempdir',
System.getProperty('org.xerial.snappy.tempdir') ?:
"${project.rootDir.absolutePath}/build/snappy_bin"
}
- // Report each test as it runs, plus a per-task summary. Gradle logs
only
- // failures by default, so a passing run prints nothing but "BUILD
SUCCESSFUL"
- // and gives no indication of which tests --tests actually selected.
- // Test stdout/stderr stays off unless asked for, since it is noisy:
- // -PshowTestOutput also forward test stdout/stderr
- // A cached or up-to-date test task forks no JVM and prints nothing;
- // add --no-build-cache --rerun to force real execution.
+ // Log skipped and failed tests, plus a per-task summary.
+ // Pass -PshowTestOutput to also forward test stdout/stderr.
testLogging {
- events 'passed', 'skipped', 'failed'
Review Comment:
In Gradle's TestLogging DSL (used in BeamModulePlugin.groovy), events
'passed' appends to the existing set rather than overriding it. Tested to be
the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
