Gaurav598 commented on code in PR #40625:
URL: https://github.com/apache/beam/pull/40625#discussion_r4290881752
##########
sdks/python/apache_beam/typehints/decorators.py:
##########
@@ -334,6 +335,25 @@ def from_callable(cls, fn: Callable) ->
Optional['IOTypeHints']:
for param in signature.parameters.values()) and
signature.return_annotation == signature.empty):
return None
+ if (any(isinstance(param.annotation, str)
Review Comment:
Fixed in `8e46db4`.
Forward-reference detection now handles nested generic annotations,
including `typing.List['int']`, `typing.Tuple['str', int]`, and `list['int']`.
Added regression tests for these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
