Gaurav598 commented on code in PR #40625:
URL: https://github.com/apache/beam/pull/40625#discussion_r4290880266
##########
sdks/python/apache_beam/typehints/decorators.py:
##########
@@ -334,6 +335,25 @@ def from_callable(cls, fn: Callable) ->
Optional['IOTypeHints']:
for param in signature.parameters.values()) and
signature.return_annotation == signature.empty):
return None
+ if (any(isinstance(param.annotation, str)
+ for param in signature.parameters.values()) or
+ isinstance(signature.return_annotation, str)):
+ try:
+ resolved = typing.get_type_hints(
+ fn.__init__ if inspect.isclass(fn) else fn)
Review Comment:
Addressed in commit `8e46db4`.
Annotations are now resolved independently, so an unresolved annotation no
longer affects valid ones. Added handling and regression coverage for partials,
callable instances, wrapped functions, constructors, and `Annotated` metadata.
The updated CI run is still in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
