Abacn commented on code in PR #40230:
URL: https://github.com/apache/beam/pull/40230#discussion_r4349732958
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/cdc/sink/CdcSinkTestUtils.java:
##########
@@ -249,4 +255,22 @@ public IcebergDestination instantiateDestination(String
destination) {
.build();
}
}
+
+ /**
+ * Dataflow Runner v2 does not carry an element's native {@link ValueKind}
yet, so a test that
+ * relies on it drops the Runner v2 experiments and runs on the legacy
worker there. This is a
+ * no-op for other runners.
+ */
+ public static void useLegacyDataflowWorker(PipelineOptions options) {
Review Comment:
This hacky override made test pass but user still see the use case breaking
in default options (managed transform enabled), as it happened in Dataflow
tests. We should disable runner v2 when ValueKind and other runner capability
not supported by portable runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
