Abacn commented on code in PR #40230:
URL: https://github.com/apache/beam/pull/40230#discussion_r4349685029
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -229,6 +240,12 @@ task dataflowIntegrationTest(type: Test) {
includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.BigQueryMetastoreCatalogIT.testWriteRead'
includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.BigQueryMetastoreCatalogIT.testReadWriteStreaming'
includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.BigQueryMetastoreCatalogIT.testStreamToPartitionedDynamicDestinations'
+ // CDC sink. The native-ValueKind round trip tests run on legacy
worker.
+ // The change-type-column tests run on Runner v2.
+ includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSource'
+ includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn'
Review Comment:
There are two tests never worked:
- changeFeedAppliesToIcebergTableWithChangeTypeColumn
- changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn
e.g. https://github.com/apache/beam/actions/runs/39764361133/job/119776009999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
