ahmedabu98 commented on code in PR #40731:
URL: https://github.com/apache/beam/pull/40731#discussion_r4351331356
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -251,10 +247,12 @@ task dataflowIntegrationTest(type: Test) {
includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.BigQueryMetastoreCatalogIT.testStreamToPartitionedDynamicDestinations'
// CDC sink. The native-ValueKind round trip tests run on legacy
worker.
// The change-type-column tests run on Runner v2.
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSource'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTable'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTableWithChangeTypeColumn'
+ if (!project.hasProperty('enableManagedTransforms')) { // temporary
mitigation until managed service upgrades to 2.77
Review Comment:
Yeah it disables all tests for managed service suite.
But btw, the same tests run on a separate Dataflow test suite without
managed service, so the test you're mentioning will still run there
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -251,10 +247,12 @@ task dataflowIntegrationTest(type: Test) {
includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.BigQueryMetastoreCatalogIT.testStreamToPartitionedDynamicDestinations'
// CDC sink. The native-ValueKind round trip tests run on legacy
worker.
// The change-type-column tests run on Runner v2.
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSource'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTable'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTableWithChangeTypeColumn'
+ if (!project.hasProperty('enableManagedTransforms')) { // temporary
mitigation until managed service upgrades to 2.77
Review Comment:
Yeah it disables all CDC tests for managed service suite.
But btw, the same tests run on a separate Dataflow test suite without
managed service, so the test you're mentioning will still run there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
