chamikaramj commented on code in PR #40731:
URL: https://github.com/apache/beam/pull/40731#discussion_r4351186553
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -251,10 +247,12 @@ task dataflowIntegrationTest(type: Test) {
includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.BigQueryMetastoreCatalogIT.testStreamToPartitionedDynamicDestinations'
// CDC sink. The native-ValueKind round trip tests run on legacy
worker.
// The change-type-column tests run on Runner v2.
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSource'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.catalog.LakehouseCatalogCdcWriteIT.changelogOfSinkWrittenTableRoundTripsThroughTheSourceWithChangeTypeColumn'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTable'
- includeTestsMatching
'org.apache.beam.sdk.io.iceberg.cdc.sink.DeltaLakeToIcebergCdcIT.changeFeedAppliesToIcebergTableWithChangeTypeColumn'
+ if (!project.hasProperty('enableManagedTransforms')) { // temporary
mitigation until managed service upgrades to 2.77
Review Comment:
Will this disable the tests for Runner v1 as well ? I noticed that we
specifically adjust the test for Runner v1 within the test execution.
https://github.com/apache/beam/blob/3d5375ac59d0a93f5537375080eb1dd43637c1d8/sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/IcebergCdcWriteBaseIT.java#L859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]