pabloem commented on a change in pull request #13017:
URL: https://github.com/apache/beam/pull/13017#discussion_r501944163
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -271,6 +276,11 @@ def __init__(self, client=None):
# randomized prefix for row IDs.
self._row_id_prefix = '' if client else uuid.uuid4()
self._temporary_table_suffix = uuid.uuid4().hex
+ self._latency_histogram_metric = Metrics.histogram(
Review comment:
I agree with Alex. We have no plans to support this in any way by
runners. It may be much simpler to just create a basic Histogram metric object
that does not integrate with the whole user metrics framework.
I feel that integrating with the user metrics framework will generate
confusion for users and developers looking at it in the future, as it is not
intended to be a user metric.
@ihji can you talk about your motivation to integrate with the user metrics
framework?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
