ajamato commented on a change in pull request #13017:
URL: https://github.com/apache/beam/pull/13017#discussion_r504283933
##########
File path: sdks/python/apache_beam/metrics/metric.py
##########
@@ -139,6 +169,22 @@ def __init__(self, metric_name):
super(Metrics.DelegatingGauge, self).__init__(metric_name)
self.set = MetricUpdater(cells.GaugeCell, metric_name) # type:
ignore[assignment]
+ class DelegatingHistogram(Histogram):
Review comment:
Please move histogram related code into a new 'internal' file
sdks/python/apache_beam/internal/metrics/metric.py
Please move DelegatingHistogram to the new file
add a Metric class to the new file, and put the histogram definition there.
It can share the infrastructure and call things in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
