sjvanrossum commented on code in PR #40788:
URL: https://github.com/apache/beam/pull/40788#discussion_r4372062083
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver.java:
##########
@@ -86,6 +89,7 @@ private CloseException() {
private int numEndpointsThatAreIncomplete;
private final AtomicBoolean consumingReceivedData;
+ private @Nullable IntConsumer onElementsConsumed;
Review Comment:
Good point, but this has been fixed by calling `queue.cancel(...)` and
branching on its return value before reading `onElementsConsumed` which ensures
that reads are ordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
