sjvanrossum commented on code in PR #40788:
URL: https://github.com/apache/beam/pull/40788#discussion_r4372114015
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataGrpcMultiplexer.java:
##########
@@ -114,6 +140,9 @@ public StreamObserver<BeamFnApi.Elements>
getOutboundObserver() {
*/
public void registerConsumer(
String instructionId, CloseableFnDataReceiver<BeamFnApi.Elements>
receiver) {
Review Comment:
I'm reasonably sure this doesn't happen in `FnHarness`.
While you could trigger this behavior in tests that wouldn't be a reflection
of the intended use.
Added a comment to highlight this potential issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
