ilyasahsan123 commented on PR #40785: URL: https://github.com/apache/beam/pull/40785#issuecomment-6420219524
> DebeziumIOPostgresSqlConnectorIT.java:216-218: please add a one line note why the replication slot is created before the inserts, the other tests let Debezium create it. > README.md: Currently the diff is only a trailing newline (which makes sense as it's a draft PR). You could document the BEGIN/END payload and the transaction key next to the withFullMetadata paragraph. > Please fill in the PR description and prepare a CHANGES.md line under 2.78.0 I/Os, feel free to extend the existing DebeziumIO entry from https://github.com/apache/beam/pull/40743. Hold the CHANGES.md line until it is approved (so it's not committed here yet), and please mention that it is also available from Python and Go via connection_properties. > Python and Go reach this through the expansion service (DebeziumTransformRegistrar builds readAsJson() and forwards connection_properties), so they get the feature with provide.transaction.metadata=true in connection_properties. The full_metadata docs in sdks/python/apache_beam/io/debezium.py and sdks/go/pkg/beam/io/xlang/debeziumio/debezium.go list the metadata fields but not the transaction key or the BEGIN/END payloads. A one line update in both would help, here or as a follow up. I have addressed the concerns noted above. When you have a moment, please review this pull request again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
