ilyasahsan123 commented on PR #40785: URL: https://github.com/apache/beam/pull/40785#issuecomment-6420181583
> SourceRecordJson.java:249-269: consider iterating value.schema().fields() as loadBefore and loadAfter do instead of hard coding the five names. transaction.metadata.factory lets users swap the struct maker, and a missing field would throw DataException here. Same for the transaction block in loadMetadataExtras: transaction.get(field) is not passed through toJsonFriendly, so a nested Struct would be reflected by Gson. Thanks for the review. The flat map approach may not provide users with a stable, documented schema. Please tell me if you would prefer an iterative approach; I can shift it from a field to a flat map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
