github-actions[bot] commented on code in PR #40821:
URL: https://github.com/apache/beam/pull/40821#discussion_r4381044705


##########
sdks/python/tox.ini:
##########
@@ -418,25 +418,31 @@ commands =
   # Allow exit code 5 (no tests run) so that we can run this command safely on 
arbitrary subdirectories.
   /bin/sh -c 'pytest -o junit_suite_name={envname} 
--junitxml=pytest_{envname}.xml -n 6 -m uses_pytorch {posargs}; ret=$?; [ $ret 
= 5 ] && exit 0 || exit $ret'
 

Review Comment:
   **🟢 Low**: Since `ml_base_core` in `setup.py` is updated to 
`onnx>=1.16.0,<2` and `onnx` up to `<2` is now supported, consider also 
removing the `onnx<1.19.0` pin in `[testenv:py311-ml]` (around line 102 of 
`tox.ini`) so the Python 3.11 ML test environment isn't artificially held back 
on an older ONNX version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to