tvalentyn commented on code in PR #40821:
URL: https://github.com/apache/beam/pull/40821#discussion_r4406440930
##########
sdks/python/setup.py:
##########
@@ -703,12 +701,16 @@ def get_portability_package_data():
],
'tfrecord': ['crcmod>=1.7,<2.0'],
'onnx': [
- 'onnxruntime==1.13.1',
- 'torch==1.13.1',
- 'tensorflow==2.11.0',
- 'tf2onnx==1.17.0',
- 'skl2onnx==1.13',
- 'transformers==4.25.1', # tensorflow transient dep
+ # Keep in line with the py311-onnx-* environments in tox.ini.
+ 'onnx>=1.16.0,<2',
+ 'onnxruntime>=1.19.0,<2',
+ # Converters for producing ONNX models from scikit-learn,
+ # TensorFlow and PyTorch models.
+ 'skl2onnx>=1.17.0,<2',
+ 'tf2onnx>=1.17.0,<1.18',
Review Comment:
do you think the upper bounds need to be for this and the below? trusting
your judgement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
