Rishavbhattarai opened a new pull request, #40865: URL: https://github.com/apache/beam/pull/40865
Fixes #18691. Ports `SplittableParDoProcessFnTest` off the deprecated `DoFnTester`. These tests drive `ProcessFn` by hand: they advance processing time, fire its timers and check the watermark hold between calls. `TestPipeline` can't do that, so I kept the `ProcessFnTester` helper and changed what's inside it: - `ProcessFn` now runs through `DoFnRunners.simpleRunner`, the same runner `SplittableProcessElementsEvaluatorFactory` uses in the DirectRunner. `StepContext` hands it the test's existing `InMemoryTimerInternals` and `TestInMemoryStateInternals`. - `close()` calls `finishBundle()` and then `ProcessFn.tearDown()`, the same order `DoFnTester.close()` used. - Outputs from the splittable invoker go into a plain list. `takeOutputElements()` and `peekOutputElementsInWindow()` read from that list, so none of the test bodies change. - Removed `DoFnTesterWindowedValueReceiver` and the `DoFnTester` import. Testing: `./gradlew :runners:core-java:test --tests SplittableParDoProcessFnTest` passes (15/15), and `spotlessCheck` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
