Rishavbhattarai commented on PR #40865: URL: https://github.com/apache/beam/pull/40865#issuecomment-6479836085
Thanks both. I kept `ProcessFnTester` because these tests check state between steps. For example, they assert the watermark hold after each `advanceProcessingTimeBy` call and the outputs before and after a checkpoint. A `TestStream` pipeline only shows the final output, so those checks would be lost rather than moved. I'm happy to keep this PR as a straight swap and open a follow-up issue for covering the end-to-end behavior with `TestStream` in `SplittableDoFnTest`, if that works for you @shunping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
