derrickaw commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4424214305
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
1. Originally `--test` was added.
2. Then docs were added stating `--tests` was to be used.
3. Another person added `--tests` and kept the backward compatible `--test`.
4. This PR completes the cycle with improved testing for both flags and
update documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
