damccorm commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4425326758
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
Ok - I think the alias is fine (it probably would've been better to just
update the docs, but that ship has sailed). But instead of alluding to both in
our docs, lets just pick one and make sure all of our docs use that. I don't
care which one we choose, but I think mentioning both (or switching back and
forth) will just confuse users and lead them to wonder which one they should
choose.
Keeping the main_test.py change is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
