damccorm commented on code in PR #40777:
URL: https://github.com/apache/beam/pull/40777#discussion_r4423044100
##########
.github/actions/setup-environment-action/action.yml:
##########
@@ -104,4 +104,4 @@ runs:
uses: actions/setup-go@v6
with:
go-version: ${{ inputs.go-version == 'default' && '1.26' ||
inputs.go-version }} # never set patch, to get latest patch releases.
- cache-dependency-path: $${{ inputs.disable-cache && '' ||
'sdks/go.sum' }}
+ cache-dependency-path: sdks/go.sum
Review Comment:
This seems good to me, but can we continue to support disabling the cache as
well? I think we can just use
https://github.com/actions/setup-go/blob/90ad2b35f69faf97585ad74d28fa006d2739b7af/action.yml#L15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
