shunping commented on code in PR #40925:
URL: https://github.com/apache/beam/pull/40925#discussion_r4444052017
##########
sdks/python/apache_beam/transforms/window_test.py:
##########
@@ -137,6 +137,14 @@ def
test_sliding_windows_assignment_fraction_large_offset(self):
self.assertEqual([IntervalWindow(4.0, 7.5), IntervalWindow(1.5, 5.0)],
windowfn.assign(context('v', 4.5)))
+ def test_sliding_windows_non_positive_period(self):
Review Comment:
Have you considered using this test for verifying the behavior of
`FixedWindows`, `SlidingWindows`, and `Sessions` when they receive invalid
input?
In this case, we need a better name for this test, and we can add a few more
scenarios too, e.g. when `size <= 0` in `SlidingWindows1, or when `gap_size <=
0` for `Session`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
