jayyyyqwq commented on PR #40925: URL: https://github.com/apache/beam/pull/40925#issuecomment-6824833184
@shunping thanks for walking through where `__init__` runs, that matches what I measured: 7 calls for 8 elements and 7 for 8,000. I pushed the broader test you asked for in dfb3b2d (`test_window_fns_reject_non_positive_parameters`: `size` for `FixedWindows` and `SlidingWindows`, `period` for `SlidingWindows`, `gap_size` for `Sessions`, with 0 and -5). @Abacn on whether a real pipeline hits it: in Beam YAML, `period: -5s` reaches `SlidingWindows` as -5.0. On master that pipeline finishes without error and emits nothing, and `period: 0s` fails with a bare `ZeroDivisionError`. I don't know of a user who hit it, so it's a guard and small in the big picture. I'm new to open source and trying to keep my PRs few and useful. Happy either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
