jrmccluskey commented on code in PR #40993:
URL: https://github.com/apache/beam/pull/40993#discussion_r4471831430
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager_continuation_test.go:
##########
@@ -366,8 +367,10 @@ func TestPersistBundle_ResidualResumeDelay(t *testing.T) {
if !ok {
t.Fatal("no processing time event scheduled for the
delayed residual")
}
- if until := fireAt.ToTime().Sub(before); until <= 0 || until >
delay {
- t.Errorf("residual release scheduled %v after
persisting, want within (0, %v]", until, delay)
+ // PersistBundle schedules the release at the delay after its
own processing
+ // time, which it reads between before and after, truncated to
milliseconds.
Review Comment:
Nit: we don't really need comments explaining the behavior here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
