Brijesh-Thakkar commented on PR #40922: URL: https://github.com/apache/beam/pull/40922#issuecomment-6688393867
Thanks for explaining, that’s fair. To be transparent: I used an AI tool (Claude Code) to help write this change and the description, and I didn’t scrutinize it as closely as I should have before asking for review. That’s on me. I’m interested in solving #40715 properly. Before writing more code, I’ll read through #40671 and #40738 and put together a short comparison of the options: annotating the ParDo directly and forwarding annotations through with_exception_handling (this PR), a RunInference-only hook, and a general with_annotations() API. I’ll cover the implications for existing annotation users and the Beam model. Would you prefer I post that on the issue or on dev@? If it turns out this needs more context than I can bring, I’m happy to unassign myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
