stankiewicz commented on code in PR #40985:
URL: https://github.com/apache/beam/pull/40985#discussion_r4473293819
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/PublishResultHandler.java:
##########
@@ -60,16 +78,18 @@ public void responseReceivedEx(Object key) {
}
private void processKey(Object key, boolean isPublished, @Nullable
JCSMPException cause) {
+ if (!(key instanceof PublishCorrelationKey)) {
Review Comment:
done
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/PublishResultHandler.java:
##########
@@ -41,12 +40,31 @@
public final class PublishResultHandler implements
JCSMPStreamingPublishCorrelatingEventHandler {
private static final Logger LOG =
LoggerFactory.getLogger(PublishResultHandler.class);
- private final BlockingQueue<PublishResult> publishResultsQueue;
private final Counter batchesRejectedByBroker =
Metrics.counter(UnboundedSolaceWriter.class, "batches_rejected");
- public PublishResultHandler(BlockingQueue<PublishResult>
publishResultsQueue) {
- this.publishResultsQueue = publishResultsQueue;
+ public PublishResultHandler() {}
+
+ public static Object correlationKey(
+ String messageId,
+ @Nullable Long publishMonotonicNanos,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
