lostluck commented on a change in pull request #13070:
URL: https://github.com/apache/beam/pull/13070#discussion_r502727024
##########
File path: sdks/go/pkg/beam/core/runtime/exec/sdf.go
##########
@@ -338,12 +348,17 @@ func (n *ProcessSizedElementsAndRestrictions)
ProcessElement(_ context.Context,
// If we need to process the element in multiple windows, each
one needs
// its own RTracker and progress must be tracked among all
windows by
// currW updated between processing.
- for _, w := range elm.Windows {
+ n.numW = len(elm.Windows)
+
+ //for _, w := range elm.Windows {
Review comment:
RM commented out line, OR swap the line below it with one that doesn't _
ignore the index. As far as I can read it,
`for i, w := range elm.Windows { ` should be identical and let you remove `w
:= elm.Windows[i]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
