youngoli commented on a change in pull request #13070:
URL: https://github.com/apache/beam/pull/13070#discussion_r503530815
##########
File path: sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go
##########
@@ -180,8 +180,8 @@ func (tracker *Tracker) TrySplit(fraction float64)
(primary, residual interface{
// GetProgress reports progress based on the claimed size and unclaimed sizes
of the restriction.
func (tracker *Tracker) GetProgress() (done, remaining float64) {
- done = float64(tracker.claimed - tracker.rest.Start)
- remaining = float64(tracker.rest.End - tracker.claimed)
+ done = float64((tracker.claimed + 1) - tracker.rest.Start)
Review comment:
Yeah, it's something I missed because I was only testing this code with
large ranges, and it's most noticeable with small ranges.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
