damccorm commented on code in PR #41174:
URL: https://github.com/apache/beam/pull/41174#discussion_r4540570103
##########
sdks/python/apache_beam/runners/worker/opcounters.py:
##########
@@ -328,16 +328,16 @@ def _should_sample(self):
if self.coder_impl is None:
return False
self._sample_counter += 1
+ if self._sample_counter < self._next_sample:
+ return False
if self._next_sample == 0:
Review Comment:
self._next_sample will only be 0 at the start and after reset is called,
otherwise it is strictly incremented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
