damccorm commented on code in PR #41174:
URL: https://github.com/apache/beam/pull/41174#discussion_r4541429940
##########
sdks/python/apache_beam/runners/worker/sdk_worker.py:
##########
@@ -117,6 +117,9 @@ def get_short_id(self, monitoring_info):
not assigned already.
"""
key = monitoring_infos.to_key(monitoring_info)
+ short_id = self._info_key_to_short_id.get(key)
Review Comment:
Fixed in 8462a399116: populated `self._short_id_to_info[shortId]` before
publishing `self._info_key_to_short_id[key] = shortId`.
##########
sdks/python/apache_beam/runners/worker/opcounters.py:
##########
@@ -346,6 +346,7 @@ def should_sample(self):
def restart_sampling(self):
self._sample_counter = 0
+ self._next_sample = 0
Review Comment:
Fixed in 8462a399116: added `test_restart_sampling_resets_next_sample` in
`opcounters_test.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
