damccorm commented on PR #41176: URL: https://github.com/apache/beam/pull/41176#issuecomment-6808939463
> Is `PGBKOperation` ever used? > > Combiner lifting builds `PGBKCVOperation` (`create_combine_per_key_precombine` in `bundle_processor.py`). The only route I can find to `PGBKOperation` is `create_operation` <- `SimpleMapTaskExecutor`, and nothing has called that since 2018. > > Is the 1.80x Dataflow figure from this change? Isn't it used here? https://github.com/damccorm/beam/blob/01b09725ec3066fcbb871bd16e54e5b5e0496865/sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py#L1389 ? Which maps to here - https://github.com/damccorm/beam/blob/01b09725ec3066fcbb871bd16e54e5b5e0496865/sdks/python/apache_beam/runners/worker/bundle_processor.py#L2041 and then that can eventually be plumbed through to https://github.com/damccorm/beam/blob/01b09725ec3066fcbb871bd16e54e5b5e0496865/sdks/python/apache_beam/runners/worker/operations.py#L1400 The 1.8 number is a composite of changes (not just this one) - I'm working attributing/prioritizing remaining work by impact before opening any new PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
