kennknowles commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r503407662
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd
${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir:
"${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
Switching to `$project.buildDir` is definitely a major improvement. Is
there a reason that tox outputs are dumped alongside the source? Is that
something we can easily control and put them in, say, `build/reports/tox` or
some such?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
