kennknowles commented on code in PR #40508:
URL: https://github.com/apache/beam/pull/40508#discussion_r4593164017


##########
sdks/rust/build.gradle:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Gradle entry point for the Rust SDK. Each area of the build is a script in 
gradle/.
+// Cargo does the real work; these tasks give maintainers the same commands as 
the rest
+// of the repository (`./gradlew :sdks:rust:build`, `:check`, `:test`).
+
+plugins { id 'org.apache.beam.module' }
+
+description = "Apache Beam :: SDKs :: Rust"
+
+apply from: 'gradle/versions.gradle'

Review Comment:
   This is OK but it is better if you can make it a proper plugin in the 
`buildSrc` magic subdirectory. There are examples there and an agent should be 
able to port it in a oneshot (or tell me why that cannot work)



##########
sdks/rust/build.gradle:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Gradle entry point for the Rust SDK. Each area of the build is a script in 
gradle/.
+// Cargo does the real work; these tasks give maintainers the same commands as 
the rest
+// of the repository (`./gradlew :sdks:rust:build`, `:check`, `:test`).
+
+plugins { id 'org.apache.beam.module' }

Review Comment:
   If you can, use `build.gradle.kts` from the outset. Adding the types reduces 
annoying stuff in the gradle builds. With agents it may or may not matter, but 
eliminating possible hallucinations and adding an automated check is still 
probably good. Beam started down this path before LLMs and never finished. If 
you actually already have a bunch of non-Kotlin gradle stuff it is fine, but 
FYI that we want it to be Kotlin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to