prodriguezdefino commented on PR #40508: URL: https://github.com/apache/beam/pull/40508#issuecomment-6934272602
Thanks for the review @kennknowles! I think I can follow the approach of having a proper module for this and grow the needed types there. I made the change in the PR to have `sdks/rust/build.gradle.kts` applying a new plugin in buildSrc, and the tasks stay the same. One question for the PRs that would follow. They add more functions to the Gradle build: - SDK container images - Prism and Dataflow launch tasks - ValidatesRunner and cross-language test suites - I/O integration tests (GCP, Kafka, Iceberg) - Quality tasks (coverage, mutation tests, complexity) and profiling - Benchmarks (harness, Nexmark, I/O) Which layout would be prefered for these? - All of them in the buildSrc plugin. - The shared part in buildSrc (cargo tasks, lint, tests, containers). The specific parts, such as benchmarks and cross-language suites, go in subprojects with their own build.gradle.kts. I would personally go with the second option, because it keeps buildSrc small. JIC, the plugin is in Groovy with @CompileStatic, like the other buildSrc plugins. Tell me if you want it in Kotlin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
