tejasiyer-dev commented on code in PR #40543:
URL: https://github.com/apache/beam/pull/40543#discussion_r4607367676


##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -2683,6 +2685,11 @@ static class StreamingShardedWriteFactory<UserT, 
DestinationT, OutputT>
           replacement = replacement.withWindowedWrites();
         }
 
+        Long directWriteThreshold = getDirectWriteThreshold(transform);
+        if (directWriteThreshold != null) {
+          replacement = 
replacement.withDirectWriteByteThreshold(directWriteThreshold);

Review Comment:
   Done. The override now reuses the user's WriteFiles and only applies 
withNumShards, instead of building a new WriteFiles.to(sink) and copying 
options onto it. Options that were being dropped on this path (batchSize, 
maxNumWritersPerBundle, the error handler, etc.) now take effect on Dataflow 
streaming.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to