reuvenlax commented on code in PR #40543:
URL: https://github.com/apache/beam/pull/40543#discussion_r4618730901
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java:
##########
@@ -1195,6 +1208,9 @@ public WriteFilesResult<DestinationT>
expand(PCollection<UserT> input) {
if (getBatchMaxBufferingDuration() != null) {
write =
write.withBatchMaxBufferingDuration(getBatchMaxBufferingDuration());
}
+ if (getDirectWriteByteThreshold() != null) {
Review Comment:
Is there a reason not to have a reasonable default, instead of defaulting to
off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]