mananmangal commented on PR #41027: URL: https://github.com/apache/beam/pull/41027#issuecomment-6968633255
Thanks @ahmedabu98. I made the parsing match `BigQueryUtils.TIMESTAMP_FORMATTER` on purpose. The `... UTC` strings in #41024 come from BigQueryIO, and I wanted a timestamp string that BigQueryIO accepts to also be accepted when writing to Iceberg. That formatter treats the date/time separator as optional and lets an offset and a zone ID appear together, with the offset taking precedence. I kept that behaviour so the two IOs would match. I have tightened it in 5302496f8d7: - Date/time separator: back to what master accepts, a `T` or a single space. `2024-10-08 T13:18:20.053`, `2024-10-0813:18:20.053` and double spaces are rejected again. - `timestamptz` without an offset or zone ID: now rejected instead of being read as UTC. - Offset plus zone ID, e.g. `2024-10-08 13:18:20.053+03:27 UTC`: now rejected. The only new format is a space and a zone ID after the time, e.g. `2024-10-08 13:18:20.053 UTC` or `2024-10-08T13:18:20.053 America/New_York`. Offsets parse as before. I also rebased on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
