tejasiyer-dev commented on code in PR #41468:
URL: https://github.com/apache/beam/pull/41468#discussion_r4628497407


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java:
##########
@@ -548,18 +548,40 @@ public void output(OutputT output, Instant timestamp, 
BoundedWindow window) {
 
         @Override
         public <T> void output(TupleTag<T> tag, T output, Instant timestamp, 
BoundedWindow window) {
-          getMutableOutput(tag)
-              .add(
-                  ValueInSingleWindow.of(
-                      output,
-                      timestamp,
-                      window,
-                      PaneInfo.NO_FIRING,
-                      null,
-                      null,
-                      CausedByDrain.NORMAL,
-                      null,
-                      ValueKind.INSERT));
+          outputWindowedValue(
+              tag, output, timestamp, Collections.singletonList(window), 
PaneInfo.NO_FIRING);
+        }
+
+        @Override
+        public void outputWindowedValue(
+            OutputT output,
+            Instant timestamp,
+            Collection<? extends BoundedWindow> windows,
+            PaneInfo paneInfo) {
+          outputWindowedValue(mainOutputTag, output, timestamp, windows, 
paneInfo);
+        }
+
+        @Override
+        public <T> void outputWindowedValue(
+            TupleTag<T> tag,
+            T output,
+            Instant timestamp,
+            Collection<? extends BoundedWindow> windows,
+            PaneInfo paneInfo) {
+          List<ValueInSingleWindow<T>> outputs = getMutableOutput(tag);
+          for (BoundedWindow window : windows) {
+            outputs.add(
+                ValueInSingleWindow.of(

Review Comment:
   Ack. Reverted from this PR and will enforce single-window in the separate 
FinishBundleContext PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to