tejasiyer-dev commented on code in PR #41468:
URL: https://github.com/apache/beam/pull/41468#discussion_r4628581368


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java:
##########
@@ -136,6 +136,43 @@ public abstract class FinishBundleContext {
      */
     public abstract <T> void output(
         TupleTag<T> tag, T output, Instant timestamp, BoundedWindow window);
+
+    /**
+     * Adds the given element to the main output {@code PCollection} at the 
given timestamp, in the
+     * given windows, and with the given {@link PaneInfo}.
+     *
+     * <p>Once passed to {@code outputWindowedValue} the element should not be 
modified in any way.
+     *
+     * <p><i>Note:</i> A splittable {@link DoFn} is not allowed to output from 
the {@link
+     * FinishBundle} method.
+     */
+    public void outputWindowedValue(

Review Comment:
   Sounds good. reverted the FinishBundleContext changes out of this PR so we 
can review WindowedValue support separately.
   
   +1 to consuming and outputting WindowedValue directly so pass-through DoFns 
like BundleLifter can buffer and re-emit elements with all metadata preserved. 
   
   I'll put together a separate PR and loop in Kenn and Radek.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to