prodriguezdefino commented on PR #41484:
URL: https://github.com/apache/beam/pull/41484#issuecomment-7020554444

   Addressed the review feedback in `37c22164ae6`:
   - `SchemaBuilder::build` delegates to `Schema::new(self.fields)` so 
`encoding_positions_set` stays consistent.
   - Removed `consumed` from this PR (no callers here), it will be `pub(crate)` 
in Part 3 where the wire-skipping helpers use it.
   - On `encoding_position: Some(0)`: nested `RowType` carries its own 
`proto::Schema` with its own `encoding_positions_set` flag, which 
`Schema::try_from` preserves. Added a rustdoc note on `TryFrom<proto::Field>` 
explaining the proto3 default of `0`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to