prodriguezdefino commented on PR #41484: URL: https://github.com/apache/beam/pull/41484#issuecomment-7021647764
Updated in `af34003ad4d`: - `Schema::new` sets `encoding_positions_set` only when all fields carry a position, `From<&Schema>` zeros positions when `encoding_positions_set` is `false`, and `TryFrom<proto::Schema>` uses `positions_set.then_some(position)`. - Removed the redundant `apache-beam-core` self-entry from `[dev-dependencies]` and `Cargo.lock`. - Kept `CoderRegistry::register_coder_with_payload`'s default and documented its intent: `Pipeline` is the only production `CoderRegistry` and implements both methods, while URN-only test registries use the default. /gemini review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
